Sales Order Payment is complicated

[ihor-sviziev]

For now this class is very complicated and hard to understand their logic
https://github.com/magento/magento2/blob/master/app/code/Magento/Sales/Model/Order/Payment.php#L1036

[ooxi]

I like how trivalent logic is implemented using true, false and -1. However it would be even better if we could replace -1 with file not found ;)

[mcspronko]

@ihor-sviziev, thank you for your note. We have plan to reducing complexity in the system. This issue will be added to our backlog. We will update you when it will be ready. Also, you may want to provide proposal on how you see this class might be refactored.

Thanks.

[vpelipenko]

Internal ticket: MAGETWO-31585

[ihor-sviziev]

Now this class logic looks much better, but now it still contains ~2600 lines of code, I think we may separate class functionality to two or more classes and use delegation.
I think first of all we should move methods like place, capture, registerCaptureNotification, refund, registerRefundNotification, accept, deny, update, authorize.

[vpelipenko]

@ihor-sviziev, when we have time we try to decrease code complexity and re-implement complicated classes in sales/payment infrastructure, but this work doesn't have high priority, that's why we can't promise that suggested refactoring will be done in the near future.

[vpelipenko]

@ihor-sviziev, we've done some work around complicated Sales Order Payment. If you compare this class in develop and master branch, you will see that about 400 lines of code were removed from it. Please, look at our changes. All feedback from your side is welcome.