Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Join extension attributes are not added to Order results (REST api) #8035

Closed
Bbbrinks opened this issue Jan 4, 2017 · 7 comments
Closed

Join extension attributes are not added to Order results (REST api) #8035

Bbbrinks opened this issue Jan 4, 2017 · 7 comments
Assignees
@swnsma
Labels
bug report Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Bbbrinks
Copy link

Bbbrinks commented Jan 4, 2017

Preconditions

  1. Magento 2.1.3
  2. PHP 7.0.8-0ubuntu0.16.04.3

Steps to reproduce

  1. Define a Extension attribute for the OrderInterface with a join table:
    <extension_attributes for="Magento\Sales\Api\Data\OrderInterface">
        <attribute code="some_id" type="string">
            <join reference_table="SOMETABLE" join_on_field="quote_id" reference_field="quote_id">
                <field>some_id</field>
            </join>
        </attribute>
    </extension_attributes>
  1. Make sure there's matching data in the SOMETABLE table and the sales_order table
  2. Request orders via REST

Expected result

  1. I expected to see some_id in the resulting json response (this does work for Quote extension attributes).

Actual result

  1. No some_id in the extension attributes property of the json response
@Bbbrinks
Copy link
Author

Bbbrinks commented Jan 4, 2017

As far as I can see there's a missing call in /magento/module-sales/Model/OrderRepository.php:

$this->extensionAttributesJoinProcessor->process($this->quoteCollection);

The //magento/module-quote/Model/QuoteRepository.php does have this call.

@veloraven veloraven added 2.1.x bug report Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog labels Jan 10, 2017
@PaulBoss
Copy link

Is there any update on this?

@magento-engcom-team magento-engcom-team added 2.1.x bug report Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 9, 2017
@magento-engcom-team magento-engcom-team self-assigned this Oct 9, 2017
@magento-engcom-team
Copy link
Contributor

@sterfpaul, thank you for your report.
We've created internal ticket(s) MAGETWO-81288 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 11, 2017
@magento-engcom-team
Copy link
Contributor

Hi @sterfpaul. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1168 by @nmalevanec in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.4 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Feb 22, 2018
@k4emic k4emic mentioned this issue Apr 10, 2018
Open
@Scarraban Scarraban mentioned this issue Jun 15, 2018
Merged
4 tasks
Scarraban added a commit to Scarraban/magento2 that referenced this issue Jul 5, 2018
@Scarraban
[Backport] magento#8035 join extension attributes not added to orders
032c82d
@sduif sduif mentioned this issue Jul 19, 2018
Closed
@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Sep 14, 2018
@sidolov
Copy link
Contributor

sidolov commented Sep 14, 2018

Hi @sterfpaul. Thank you for your report.
The issue has been fixed in #16169 by @Scarraban in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.16 release.

magento-engcom-team added a commit that referenced this issue Sep 14, 2018
@magento-engcom-team
ENGCOM-2933: [Backport] #8035 join extension attributes not added to …
3cc55a0 
…orders #16169

 - Merge Pull Request #16169 from Scarraban/magento2:backport-8035
 - Merged commits:
   1. 032c82d
   2. 27bdf61
magento-engcom-team pushed a commit that referenced this issue Sep 14, 2018
ENGCOM-2933: [Backport] #8035 join extension attributes not added to …
931170a 
…orders #16169
@Bbbrinks Bbbrinks mentioned this issue Nov 7, 2018
Open
@Ian410 Ian410 reopened this Feb 28, 2019
@Ian410
Copy link
Member

Ian410 commented Feb 28, 2019

This seems to have been removed in 2.3, or was never included in the first place. I can't find any commit removing it, why was it?

@nmalevanec nmalevanec removed their assignment Mar 1, 2019
swnsma pushed a commit to swnsma/magento2-1 that referenced this issue Mar 16, 2019
@nmalevanec
magento#8035: Join extension attributes are not added to Order result…
961e05c 
…s (REST api)
This was referenced Mar 16, 2019
Merged
Merged
@ghost ghost assigned swnsma Apr 2, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Apr 23, 2019
@magento-engcom-team
Copy link
Contributor

Hi @Bbbrinks. Thank you for your report.
The issue has been fixed in #21797 by @swnsma in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swnsma swnsma

Labels
bug report Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@Ian410 @Bbbrinks @veloraven @PaulBoss @swnsma @sidolov @nmalevanec @misha-kotov @magento-engcom-team