Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup-Modal not closing on Safari/Windows #8761

Closed
taschert opened this issue Mar 2, 2017 · 3 comments
Closed

Popup-Modal not closing on Safari/Windows #8761

taschert opened this issue Mar 2, 2017 · 3 comments
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@taschert
Copy link

taschert commented Mar 2, 2017

When i close a popup on Safari the overlay stay open.

Preconditions

Windows 10
Safari 5.1.7
Magento 2.1

Steps to reproduce

  1. Add an item to cart
  2. Open the mini-cart
  3. Click on remove the item from the cart
  4. Validate or cancel the action

Expected result

  1. The popup should close and the grey overlay disappear

Actual result

  1. The popup is close but i still have the grey overlay over all the webite
  2. The only way to remove the overlay is to refresh the page or edit html

The issue is in \vendor\magento\module-ui\view\base\web\js\modal\modal.js

In this file, in the function the function that._close(); is never called.

closeModal: function () {
            var that = this;

            this._removeKeyListener();
            this.options.isOpen = false;
            this.modal.one(this.options.transitionEvent, function () {
                that._close();
            });
            this.modal.removeClass(this.options.modalVisibleClass);

            if (!this.options.transitionEvent) {
                that._close();
            }

            return this.element;
        },
@taschert taschert changed the title Popup-Model not closing on Safari/Windows Popup-Modal not closing on Safari/Windows Mar 2, 2017
@magento-team magento-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development develop labels Jul 31, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-67320

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development develop Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team
Copy link
Contributor

@taschert thank you for your report.
The fix for this issue is already available in release 2.2.0

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Sep 20, 2017
@nntoan
Copy link
Contributor

nntoan commented Nov 29, 2017

@magento-engcom-team Can you please link the commit into this ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

4 participants