Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup-Modal not closing on Safari/Windows #8824

Merged
merged 1 commit into from
Apr 13, 2017

Conversation

HansSchouten
Copy link
Contributor

@HansSchouten HansSchouten commented Mar 8, 2017

This pull request is a fix for issue: #8761

The first thing I noticed when looking into the css was that the -webkit-transition-duration was missing. Therefore, the transition event was never triggered in Safari. The modal directly popped up on clicking the remove item button in the shopping cart.
After adding the transition duration, Safari did no longer show the modal at all. This was because the visibility transition acts on the parent, while the transition is set on its child. I divided the animation into a visibility transition at the parent .modal-slide, .modal-popup and a transform transition at its child .modal-inner-wrap. As a result, Safari users can now remove items from cart without the need to refresh a greyed out page.

While debugging I replicated the issue in JSFiddle:
http://jsfiddle.net/muL7Lpnx/
And wrote the following fix:
http://jsfiddle.net/muL7Lpnx/1/

After updating the Magento Less source files, I successfully tested the fix in the following browsers:
Safari 5.1.7
Chrome 56
IE 11
Microsoft Edge 38
Firefox 50.1.0
Opera 43

@okorshenko okorshenko self-assigned this Mar 16, 2017
@okorshenko okorshenko added this to the March 2017 milestone Mar 16, 2017
@okorshenko okorshenko modified the milestones: March 2017, April 2017 Apr 2, 2017
@magento-team magento-team merged commit 27405be into magento:develop Apr 13, 2017
@magento-team
Copy link
Contributor

@HansSchouten Thank you for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants