Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Flat Category reindexList of AllChildren if the url_key of t… #10557

Merged
merged 3 commits into from Sep 4, 2017

Conversation

lewisvoncken
Copy link
Contributor

@lewisvoncken lewisvoncken commented Aug 16, 2017

When Flat Category is enabled and you change the url_key of a category which has children the url_paths of the children won't be updated.

This can be reproduced by following these steps:

1. Enable Flat Catalog Category
Stores > Settings > Configuration > Catalog > Catalog > Storefront > Use Flat Catalog Category
2. Reindex through the console
bin/magento indexer:reindex
3. Open the flat table which is generated after the first reindex of Flat Catalog Category
4. Search for an example category which has children
In the example data Women category with ID 20 .
5. List the url_paths of the sub children
SELECT url_path, path FROM catalog_category_flat_store_1 WHERE path LIKE '%20%'
6. Open the example category in the Magento Admin Panel
7. Change the Url Key of the category and Save the category
8. Check the database again and you will see the following result

image

But the children should also be updated, after the fix the result will be like this:

image

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 16, 2017

CLA assistant check
All committers have signed the CLA.

@ishakhsuvarov
Copy link
Contributor

Hi @lewisvoncken
Thank you for the Pull Request. Please sign the CLA so that we could proceed with the processing.

@ishakhsuvarov
Copy link
Contributor

@lewisvoncken I assume develop branch may also be affected by this issue. Do you plan to implement it for up-to-date version as well? Would you like to cover changes with some kind of tests?

@vkublytskyi
Copy link

@ishakhsuvarov PR to develop branch was created as magento-partners/magento2ce#7

@okorshenko
Copy link
Contributor

waiting for develop branch PR. Once it is merged, we will proceed with this PR

@lewisvoncken
Copy link
Contributor Author

@vkublytskyi updated this pull request according to the feedback on the develop branch pr

magento-team pushed a commit that referenced this pull request Sep 4, 2017
magento-team pushed a commit that referenced this pull request Sep 4, 2017
[EngCom] Public Pull Requests - 2.1
 - MAGETWO-72252: Backport of MAGETWO-52577 for Magento 2.1: [GitHub] Set Product as Ne… #10751
 - MAGETWO-72251: Backport of MAGETWO-65607 for Magento 2.1: [GitHub][PR] Check return … #10750
 - MAGETWO-71643: [BUGFIX] Flat Category reindexList of AllChildren if the url_key of t… #10557
@magento-team magento-team merged commit bee5fdd into magento:2.1-develop Sep 4, 2017
magento-team pushed a commit that referenced this pull request Sep 4, 2017
lewisvoncken added a commit to experius/devdocs that referenced this pull request Sep 21, 2017
This feature makes it possible to easily switch between store codes in Swagger without changing the swagger-ui template but through adding a store param to the url. With this feature it is possible to test API calls in Swagger for different storeviews.

See following pull request for additional information:

https://github.com/magento-partners/magento2ce/pull/10

https://github.com/magento-partners/magento2ce/pull/9

magento/magento2#10557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants