Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response condition order changes. #10826

Merged
merged 4 commits into from Sep 13, 2017
Merged

response condition order changes. #10826

merged 4 commits into from Sep 13, 2017

Conversation

RakeshJesadiya
Copy link
Contributor

@RakeshJesadiya RakeshJesadiya commented Sep 9, 2017

When Customer login from checkout page, need to redirect customer to account dashborad page from checkout page.

By default Customer Login from checkout page, stays into same page but where need to redirect customer to account dashboard page. we need to create plugin and set response as redirect url into magento customer module.

After create plugin we need to override login.js file cause of response.redirectUrl call condition in elseif.
So if response with redirectUrl is set then first redirect to those action instead of default action.

Check real issue from magento forum,Forum Question

@ishakhsuvarov
Copy link
Contributor

Hi @RakeshJesadiya
Please take a look at the JavaScript Static tests failure on Travis CI

Thanks

@RakeshJesadiya
Copy link
Contributor Author

Hi @ishakhsuvarov, What to do for Travis CI, I am not known for those. Any guidance would be appericiated.

@orlangur
Copy link
Contributor

@RakeshJesadiya error is quite clear: https://travis-ci.org/magento/magento2/jobs/273575190#L817

First the if was not aligned properly, now empty line is missing. Please squash your changes into single commit and force push after build is green.

@magento-team magento-team merged commit c813f51 into magento:develop Sep 13, 2017
magento-team pushed a commit that referenced this pull request Sep 13, 2017
[EngCom] Public Pull Requests
 - MAGETWO-72486: response condition order changes. #10826
 - MAGETWO-72465: Enable livereload for watch: commands #10836
 - MAGETWO-72428: Close PayPal popup window in case of rejected request #10820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants