Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10417 #11048

Merged
merged 4 commits into from Oct 4, 2017

Conversation

@PieterCappelle
Copy link
Contributor

commented Sep 26, 2017

When adding images in CMS Pages / Blocks or Catalog and Category the path to the image is incorrect. When you insert image in 2.1.8, we get <p><img src="{{media url="wysiwyg/Hond.jpg"}}" width="1024" height="683" /></p> when we insert image in 2.1.9 <p><img src="http://local.magento/admin/cms/wysiwyg/directive/___directive/e3ttZWRpYSB1cmw9Ind5c2l3eWcvVmVsZC5qcGcifX0%2C/key/d3f89696a93152f6d352e5d5cb391180a27c8a7924d9fe3b583d3e9f03d00753/" width="959" height="1024" /></p>

The issue is also a problem in 2.2-develop. This fix is for 2.2-develop. Will create backport voor 2.1-develop branch.

Fixed Issues (if relevant)

  1. #10417

Manual testing scenarios

  1. Go to CMS Pages.
  2. Add image
  3. Check the path (show/hide editor)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
heyitsroberthe and others added 2 commits Sep 13, 2017
Merge pull request #1483 from magento-mpi/MAGETWO-72551
[mpi] MAGETWO-72551: Update version in composer to 2.2.1-dev for 2.2-develop branch
@hostep

This comment has been minimized.

Copy link
Contributor

commented on lib/internal/Magento/Framework/App/Request/Http.php in c3ea1f5 Sep 13, 2017

@heyitsroberthe: I hope you tested switching between multiple storeviews using the store switcher after this change, because this code also lives in 2.1 and gives troubles which I noted down a couple of weeks ago over here: a2f2893#commitcomment-23494452 and 508f1ef#commitcomment-23479499 and #8509 (comment)

I haven't actually tested after this commit, so I might be wrong, but I have the feeling 2.2.0 will now have the same issue because of this change where you can have ?___store=storeLanguage1?___store=storeLanguage2 in the url after using the store switcher multiple times.

Also what's up with the removeRepitedSlashes method name? Should be removeRepeatedSlashes ;)

@magento-team magento-team force-pushed the magento:2.2-develop branch from 0c0393d to e442de5 Sep 26, 2017

@vrann vrann self-assigned this Sep 28, 2017

@vrann vrann added this to the September 2017 milestone Sep 28, 2017

@vrann vrann reopened this Sep 29, 2017

@magento-cicd2

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

PieterCappelle
paliarush
viktym

@PieterCappelle

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2017

Please merge this. I will create backport for 2.1.

@PieterCappelle PieterCappelle referenced this pull request Oct 2, 2017

@okorshenko okorshenko merged commit 202dd82 into magento:2.2-develop Oct 4, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
okorshenko pushed a commit that referenced this pull request Oct 4, 2017
@PieterCappelle

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2017

Thanks. I'll create backport to 2.1 branch.

@PieterCappelle PieterCappelle deleted the PieterCappelle:fix_wysiwyg branch Oct 5, 2017

@PieterCappelle PieterCappelle referenced this pull request Oct 9, 2017
4 of 4 tasks complete
@kenmaxnejp

This comment has been minimized.

Copy link

commented on 6237877 Oct 17, 2017

Thanks! It works in Magento 2.2.0, I posted those images all over again and it works. Actually I cannot find app/code/Magento/Cms/Helper/Wysiwyg/Images.php, so I edited vendor/magento/module-cms/Helper/Wysiwyg/Images.php instead.

This comment has been minimized.

Copy link

replied Nov 8, 2017

this works in chrome but nor safari or firefox

This comment has been minimized.

Copy link

replied Nov 29, 2017

I am not a programmer so I could be completely wrong. This seems to be broken in 2.2.1 for custom attributes if called by a new .phtml file with the following content: looks like I am having hard time posting the code, Anyway,

getProduct(); ?> getData('protocol'); ?>

But does show correctly by the default "more information" tab.
Is that my .phtml file is not written correctly?

@Vishrootways

This comment has been minimized.

Copy link

commented Apr 3, 2018

How to solve this error in Magento 2.1.8 version? Please help us if anyone know.

@treii28

This comment has been minimized.

Copy link

commented Jun 4, 2018

I'm on v2.2.2 and still experiencing this issue? What is necessary to resolve it as from what I'm reading here, it's supposed to be fixed in my version. Furthermore, if and when these links sneak into the database, they create hung apache threads whenever a page tries to access one and the things linger in a 'closing' status on the server and eat up 100% cpu until I kill -HUP them manually. I want it fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.