Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added carrier code to ID to distinguish shipping methods [backport 2.1] #11456

Merged
merged 1 commit into from Oct 18, 2017

Conversation

peterjaap
Copy link
Contributor

Added carrier code to ID to distinguish shipping methods with the same method name but differing carrier code

Shipping method radios have duplicate element IDs on cart page, which makes it impossible to select the second method.

Description

Make the element ID unique by adding in the carrier code into the ID.

Fixed Issues (if relevant)

  1. Shipping method radios have duplicate IDs on cart page #10795: Shipping method radios have duplicate IDs on cart page

Manual testing scenarios

  1. Create a shipping method with a unique carrier name but a method name that is in use, such as 'freeshipping' (make sure to of course enable the freeshipping option and have it appear in the checklist).

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants