Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE-10811][BUGFIX] Update .htaccess.sample to replace FollowSymLin… #11461

Merged
merged 2 commits into from Nov 9, 2017
Merged

[ISSUE-10811][BUGFIX] Update .htaccess.sample to replace FollowSymLin… #11461

merged 2 commits into from Nov 9, 2017

Conversation

sylvainraye
Copy link
Contributor

@sylvainraye sylvainraye commented Oct 14, 2017 •
edited by ihor-sviziev

…ks with SymLinksIfOwnerMatch

Improve security of symlink on .htaccess level

Description

Update .htaccess.sample to replace FollowSymLinks with SymLinksIfOwnerMatch

Fixed Issues (if relevant)

  1. Replace FollowSymLinks with SymLinksIfOwnerMatch #10811: Replace FollowSymLinks with SymLinksIfOwnerMatch

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners dmanners self-assigned this Oct 24, 2017
@dmanners dmanners added this to the October 2017 milestone Oct 24, 2017
@dmanners dmanners added Release Line: 2.2 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Oct 24, 2017
dmanners
dmanners suggested changes Oct 24, 2017
View reviewed changes
.htaccess.sample Outdated
@@ -111,7 +111,9 @@
############################################
## enable rewrites

Options +FollowSymLinks
# Options +FollowSymLinks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest that we could remove this line completely here.

@okorshenko okorshenko modified the milestones: October 2017, November 2017 Nov 1, 2017
@okorshenko okorshenko merged commit fd17ca1 into magento:2.2-develop Nov 9, 2017
okorshenko pushed a commit that referenced this pull request Nov 9, 2017
@ishakhsuvarov
MAGETWO-82634: [ISSUE-10811][BUGFIX] Update .htaccess.sample to repla…
2270483 
…ce FollowSymLin… #11461
@magento-engcom-team magento-engcom-team added Fixed in 2.2.x The issue has been fixed in 2.2 release line Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanners dmanners dmanners approved these changes

Assignees

@dmanners dmanners

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sylvainraye @dmanners @magento-team @okorshenko @magento-engcom-team