Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for remove 'product_list_toolbar' block from layout in XML #9413 #11473

Merged
merged 12 commits into from
Nov 25, 2017

Commits on Oct 15, 2017

  1. solve the toolbar problem when this is removed from the layout, code …

    …format on construcor of the product list block class
    mariuscris committed Oct 15, 2017
    Configuration menu
    Copy the full SHA
    42072dd View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2017

  1. Remove the product list helper from constructor for backward compatib…

    …ility. Use the default toolbar to get current listing mode. Refactor the code.
    mariuscris committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    9dbe444 View commit details
    Browse the repository at this point in the history
  2. refactor the code on get toolbar block from layout, fix condition on …

    …using the mode layout configuration
    mariuscris committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    49fdfae View commit details
    Browse the repository at this point in the history
  3. Update the toolbar test with product list collection. The toolbar HTM…

    …L depends on product collection. Because you can remove the toolbar from layout, there is no reason for parent class to add the product collection to default toolbar if the toolbar is never used. That is why the test toolbar coverage needs to include a product collection before checking the toolbar HTML.
    mariuscris committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    b6ed2d9 View commit details
    Browse the repository at this point in the history
  4. Update the toolbar coverage test to use the a layout toolbar declarat…

    …ion present in default layout. Remove the previews correction made because it's not solve the problem where is checking if the toolbar HTML is not empty.
    mariuscris committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    9cd20c0 View commit details
    Browse the repository at this point in the history
  5. fix static line limit test

    mariuscris committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    2adefdf View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2017

  1. Remove FQCN

    Remove FQCN
    mariuscris committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    cbda7b8 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2017

  1. Configuration menu
    Copy the full SHA
    992b3a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4e937a3 View commit details
    Browse the repository at this point in the history
  3. import Config class

    mariuscris committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    c303e4d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cd7dc56 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2017

  1. Configuration menu
    Copy the full SHA
    6162464 View commit details
    Browse the repository at this point in the history