Small improvement to the eval() call #1162
Conversation
http://php.net/manual/en/function.eval.php > eval() returns NULL unless return is called in the evaluated code, > in which case the value passed to return is returned. > If there is a parse error in the evaluated code, > eval() returns FALSE and execution of the following code continues normally. A 'return' statement seems a more elegant way of handling this than using `$result = `. The behavior remains unchanged. If an error happens eval() will return `False` so $return will retain it's `False` if that happens,
|
Thoughts on trying to remove the eval entirely? It looks like the code is using eval to try to process boolean logic for filters and filter groups. Rewriting the code to avoid eval would be both safer and easier to maintain/read. |
|
I'm not really a magento person, so I wouldn't know really =) But if it's not eval-ing user editable content there is really no danger to it imho. eval() is not that different to require and include in that case. |
|
@dracony - I still wouldn't use it. It has a bad reputation. If there's now way out of using it, yeah, sure. But there usually is. Oh, and because of the Suhosin Extension and security admins. Why would Magento stop working because someone decided against |
|
Created internal issue to get rid of evals throughout the code. |
[TSG] Backporting for 2.1 (pr16) (2.1.8)
…w an error if order doesn't exist. #1162
http://php.net/manual/en/function.eval.php
A 'return' statement seems a more elegant way of handling this than using
$result =. The behavior remains unchanged. If an error happens eval() will returnFalseso $return will retain it'sFalseif that happens,