Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check attribute unique between same fields in magento commerce [backport] #11622

Merged
merged 1 commit into from Nov 6, 2017
Merged

Check attribute unique between same fields in magento commerce [backport] #11622

merged 1 commit into from Nov 6, 2017

Conversation

raumatbel
Copy link
Contributor

@raumatbel raumatbel commented Oct 21, 2017 •
edited

Related with the PR11620

Description

Check attribute unique in Magento Commerce (EE) correctly

Steps to reproduce

In Magento Commerce (EE).

  1. Create a custom attribute unique and add it to the attribute set.
  2. Create a new value for this attribute in a product and save it.
  3. Save the product again.*

*If for any reason, the value row_id is different and entity_id. The check return how if the product to validate are different.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko self-assigned this Oct 27, 2017
@okorshenko okorshenko added this to the October 2017 milestone Oct 27, 2017
@okorshenko okorshenko modified the milestones: October 2017, November 2017 Nov 1, 2017
@magento-team magento-team merged commit 737a76b into magento:2.3-develop Nov 6, 2017
magento-team pushed a commit that referenced this pull request Nov 6, 2017
@ishakhsuvarov
MAGETWO-82951: Check attribute unique between same fields in magento …
81d99b5 
…commerce [backport] #11622
magento-team pushed a commit that referenced this pull request Nov 6, 2017
@ishakhsuvarov
Merge pull request #1667 from magento-engcom/develop-prs
4ee8196 
[EngCom] Public Pull Requests - develop
 - MAGETWO-83276: [2.3] Magento 2 Store Code validation regex: doesn't support uppercase letters in store code #12010
 - MAGETWO-82951: Check attribute unique between same fields in magento commerce [backport] #11622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raumatbel @magento-team @okorshenko