save invoice ID on credit memo when using API method salesRefundInvoiceV1 #11670
Conversation
| * @deprecated | ||
| */ | ||
| private function getInvoiceRepository() { | ||
| return $this->invoiceRepository ?: ObjectManager::getInstance()->get(InvoiceRepositoryInterface::class); |
There was a problem hiding this comment.
Please avoid such methods creation and move this logic to constructor.
In the IpnTest creates a creditmemo for the invoice in $ipnModel->processIpnRequest() already So if Magento/Paypal/_files/order_express_with_invoice_and_creditmemo.php is used, the invoice is already refunded before the start of the test
|
@orlangur tests passing |
|
Fixes same issue as #11687 |
|
@ajpevers I would suggest aligning solutions as #11687 seems to be more lightweight (however from code review only I can not see if it really fixes all cases), but this PR includes integration test, which is preferred. |
|
Hello @ishakhsuvarov, Although the solution there is more lightweight, it is not in line with the rest of the code. The problem in #11669 brings to light that a credit memo - invoice relation is not saved automatically. In this case in the salesRefundInvoiceV1 API call. Other relations are always saved, such als the credit memo - order relation. No matter how or from which part of the code you save the credit memo, because it is done in the same _beforeSave as my addition. My solution is in line with the credit memo - order relation persistence code. It works in all instances. Not only in the API. Especially with these essential entities in the system I would not go for end of pipe solutions such as #11687. As far as the unit testing goes. I would not know how to test the _beforeSave of a resource model. For now that goes beyond my knowledge of unit testing. As far as I can see the unit test for checking if the order ID is persisted on the credit memo is also lacking. So it would be a shame to keep this PR open for that reason in my opinion. |
magento-engcom-team
added
2.2.x
Reproduced on 2.2.x
| @@ -379,6 +389,9 @@ public function canRefund() | |||
| */ | |||
| public function getInvoice() | |||
| { | |||
| if (!$this->getData('invoice') instanceof \Magento\Sales\Model\Order\Invoice && $this->getInvoiceId()) { | |||
There was a problem hiding this comment.
Is there a reason not to use \Magento\Sales\Api\Data\InvoiceInterface here?
There was a problem hiding this comment.
Good point. No there is no reason.
…is set on the credit memo
…to2 into issue-11669
…alesRefundInvoiceV1 #11670
[EngCom] Public Pull Requests - 2.2-develop - MAGETWO-83552: save invoice ID on credit memo when using API method salesRefundInvoiceV1 #11670 - MAGETWO-82577: [Backport 2.2] Translate order getCreatedAtFormatted() to store locale #11422 - MAGETWO-84474: 10128: New Orders not being saved to order grid #12241 - MAGETWO-83783: Shipping method fixtures not compatible with getShippingMethod(true) in OrderCreateTest #12227 - MAGETWO-83290: Add swatch option: Prevent loosing data and default value if data is not populated via adminhtml #12036 - MAGETWO-83741: 11740: Sending emails from Admin in Multi-Store Environment defaults to Primary Store #11992 - MAGETWO-83399: Fix for remove 'product_list_toolbar' block from layout in XML #9413 #11473
Description
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist