Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug: Customer import deletes exiting customer entity Fields #11968

Merged
merged 2 commits into from Nov 10, 2017
Merged

Fix bug: Customer import deletes exiting customer entity Fields #11968

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6c6e66
Fix bug that deletes exiting customer entity Fields, if the columns a…
jalogut Nov 2, 2017
3ae0785
Filter the import to make sure we only update fields present in the i…
dmanners Nov 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion app/code/Magento/CustomerImportExport/Model/Import/Customer.php
View file
Open in desktop
Expand Up @@ -270,13 +270,23 @@ protected function _saveCustomerEntities(array $entitiesToCreate, array $entitie
$this->_connection->insertOnDuplicate(
$this->_entityTable,
$entitiesToUpdate,
$this->customerFields
$this->getCustomerEntityFieldsToUpdate($entitiesToUpdate)
);
}

return $this;
}

private function getCustomerEntityFieldsToUpdate(array $entitiesToUpdate): array
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe a docblock to this method with a short explanation of the bug this method fixes. Is there actually a github issue for this fix cause you could add a link to that here.

{
$firstCustomer = reset($entitiesToUpdate);
$columnsToUpdate = array_keys($firstCustomer);
$customerFieldsToUpdate = array_filter($this->customerFields, function ($field) use ($columnsToUpdate) {
return in_array($field, $columnsToUpdate);
});
return $customerFieldsToUpdate;
}

/**
* Save customer attributes.
*
Expand Down