Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport 2.1] Magento 2 Store Code validation regex: doesn't support uppercase letters in store code #12040

Merged
merged 1 commit into from
Nov 7, 2017
Merged

[backport 2.1] Magento 2 Store Code validation regex: doesn't support uppercase letters in store code #12040

merged 1 commit into from
Nov 7, 2017

Conversation

manuelson
Copy link
Contributor

Description

Magento 2 Store Code validation regex: doesn't support uppercase letters in store code

Fixed Issues (if relevant)

  1. Magento 2 Store Code validation regex: doesn't support uppercase letters in store code #11996: Magento 2 Store Code validation regex: doesn't support uppercase letters in store code

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@vkublytskyi vkublytskyi self-assigned this Nov 6, 2017
@vkublytskyi vkublytskyi added this to the November 2017 milestone Nov 6, 2017
@vkublytskyi vkublytskyi added Release Line: 2.1 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 6, 2017
@magento-team magento-team merged commit 767da58 into magento:2.1-develop Nov 7, 2017
magento-team pushed a commit that referenced this pull request Nov 7, 2017
@ishakhsuvarov
MAGETWO-83319: [backport 2.1] Magento 2 Store Code validation regex: …
79f9c76 
…doesn't support uppercase letters in store code #12040
magento-team pushed a commit that referenced this pull request Nov 7, 2017
@ishakhsuvarov
Merge pull request #1669 from magento-engcom/2.1-develop-prs
1d083d4 
[EngCom] Public Pull Requests - 2.1-develop
 - MAGETWO-83320: #7903 correct the position of the datepicker when you scroll #12045
 - MAGETWO-83319: [backport 2.1] Magento 2 Store Code validation regex: doesn't support uppercase letters in store code #12040
 - MAGETWO-82948: fix #8846 [Backport 2.1-develop]: avoid duplicated attribute option values #11786
 - MAGETWO-81328: [Fix:5439] Send email to subscribers only when are new 2.1 #11316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vkublytskyi vkublytskyi

Labels
Progress: accept Release Line: 2.1 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manuelson @magento-team @vkublytskyi