Category page X-Magento-Tags headers contains product cache identities even which category display mode is set to "Static block only" #12466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very interesting, will check in detail and report back. Thanks @atishgoswami! |
|
This is in process of merging. Can you please port your changes to 2.1 and 2.3? Thanks a lot! |
|
@miguelbalparda Thanks for reviewing it so quickly. I will create 2 new pull request for porting to 2.1-develop and 2.3-develop branches |
magento-team
pushed a commit
that referenced
this pull request
Dec 1, 2017
…cache identities even which category display mode is set to "Static block only" #12466
This was referenced Dec 2, 2017
|
@miguelbalparda Created 2 new PRs #12523 and #12522 for magento version 2.1 and 2.3 |
okorshenko
pushed a commit
that referenced
this pull request
Dec 11, 2017
okorshenko
pushed a commit
that referenced
this pull request
Dec 11, 2017
[EngCom] Public Pull Requests - develop - MAGETWO-85026: [Backport 2.3] #12450: Set Current Store from Store Code if isUseStoreInUrl #12545 - MAGETWO-85016: 12111: Missing cascade into attribute set deletion.[port] #12538 - MAGETWO-84980: Trying to get data from non existent products #12540 - MAGETWO-84933: PR #12466 [BACKPORT 2.3] #12523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When varnish is selected as the cache engine, If there are products associated to a respective category, and the category
display modeis set toStatic block only, on the category pageX-Magento-Tagsheaders contains product item cache identities even when no product is displayed for the page.This PR will:
Magento\Catalog\Model\Product::CACHE_TAGcache identities to be generated if the category pageDisplay Modeis set toStatic block onlyFixed Issues (if relevant)
None, code improvement
Contribution checklist