Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution For Newsletter subscribe button title wrapped #13041

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Solution For Newsletter subscribe button title wrapped #13041

merged 1 commit into from
Jan 9, 2018

Conversation

monaemipro
Copy link

@monaemipro monaemipro commented Jan 7, 2018 •
edited
Loading

Solution For Newsletter subscribe button title wrapped.

Description

Fixed Issues (if relevant)

  1. Newsletter subscribe button title wrapped #12320: Newsletter subscribe button title wrapped

Manual testing scenarios

  1. Change text of newsletter button to Chinese word "订阅" which must be wrapped in one line.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 7, 2018
@mzeis mzeis self-assigned this Jan 8, 2018
@mzeis mzeis added this to the January 2018 milestone Jan 8, 2018
@magento-team magento-team mentioned this pull request Jan 9, 2018
Closed
magento-team pushed a commit that referenced this pull request Jan 9, 2018
MAGETWO-86447: Solution For Newsletter subscribe button title wrapped #…
cfbf87e 
…13041
@magento-team magento-team merged commit d9536c8 into magento:2.2-develop Jan 9, 2018
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 9, 2018
@mzeis
Copy link
Contributor

mzeis commented Jan 9, 2018

Thanks for your PR @monaemipro! It has been merged into 2.2-develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzeis mzeis

Labels
bugfix Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@monaemipro @mzeis @magento-team @magento-engcom-team @mayankzalavadia