Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13582 show message for qty minAllowed, maxAllowed, qtyIncremen… #13942

Merged
merged 4 commits into from Apr 2, 2018

Conversation

bordeo
Copy link

@bordeo bordeo commented Mar 4, 2018

…ts validation. Fix ProductView plugin for maxAllowed

Product with max sale qty, min sale qty or increment qty will not show error message on frontend

Description

Fixed how Plugin extract max sale qty
Add parametric message for js validation

Fixed Issues

  1. Magento 2.1.11 minimum quantity validation message not showing #13582: Magento 2.1.11 minimum quantity validation message not showing

Manual testing scenarios

  1. Set Min sale qty (3), max sale qty (100) or qty increments (3) on a simple product visible in catalog
  2. Try to add that product to cart with qty that triggers the js validation error. eg: 0, 2, 7, 101

@okorshenko
Copy link
Contributor

@magento-engcom-team give me new test instance

@magento-engcom-team
Copy link
Contributor

Hi @okorshenko, here is your new test Magento instance

@okorshenko
Copy link
Contributor

Hi @bordeo
Thank you for your first contribution! We deployed test instance for you. Could you please configure the instance with test data to demonstrate your fix? Admin access: /admin admin:123123q
http://pr-13942.engcom.dev.magento.com/

@bordeo
Copy link
Author

bordeo commented Mar 27, 2018

Sure, here the product with min qty, qty increments and max qty working and with the validation errors.
http://pr-13942.engcom.dev.magento.com/ps4-console.html

@magento-engcom-team
Copy link
Contributor

@bordeo thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@bordeo
Copy link
Author

bordeo commented Mar 29, 2018

@magento-engcom-team thank you.
If you need more details for testing the code, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants