Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json and xml support to the post method in socket client #14169

Merged

Conversation

simpleadm
Copy link
Contributor

Added json and xml support to the post method in \Magento\Framework\HTTP\Client\Socket class

Description

In Pull Request #8373 was added ability to use json and xml in \Magento\Framework\HTTP\Client\Curl class, but in the class \Magento\Framework\HTTP\Client\Socket, which implements the same interface, that functionality wan't added. So current PR will fix it.

Related issue and PRs

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur
Copy link
Contributor

Hi @simpleadm, the changes looks good to me, however, we need to deliver them into 2.2-develop branch first in order to get this PR processed. Could you please prepare such a new pull request against 2.2-develop target branch.

@simpleadm
Copy link
Contributor Author

Hi @orlangur , easy :)
For 2.2-develop #14347
For 2.1-develop #14348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants