magento/magento2#13765 Excess requests 'customer data' on checkout cart page were fixed #14314

andrewbess · 2018-03-24T12:23:05Z

Description

The customer/section/load gets called 4 times when loading the cart for the first time. 3 of those times, cart data gets returned. On Magento 2.1, I believe only two calls are made to customer/section/load.

Fixed Issues (if relevant)

"cart" section data gets loaded 3 times on cart page (2.2.2) #13765: "cart" section data gets loaded 3 times on cart page (2.2.2)

Steps to reproduce

Add any product to cart
Go to cart page /checkout/cart with the "Network" panel open in DevTools.

Expected result

The /customer/section/load url should only get called twice. For example, these are the two urls that get called on a Magento 2.1 install:

https://magento22.dev/customer/section/load/?sections=&update_section_id=false&_=1519190370042
https://magento22.dev/customer/section/load/?sections=directory-data&update_section_id=false&_=1519190370043

Actual result

The /customer/section/load url will get called four times:

https://magento22.dev/customer/section/load/?sections=&update_section_id=false&_=1519190370042
https://magento22.dev/customer/section/load/?sections=directory-data&update_section_id=false&_=1519190370043
https://magento22.dev/customer/section/load/?sections=cart&update_section_id=false&_=1519190370045
https://magento22.dev/customer/section/load/?sections=cart&update_section_id=false&_=1519190370046

Note: if you refresh the cart, there will only be two calls made to /customer/section/load.

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

…ere fixed: - Excess request for 'directory-data' was fixed; - Excess requests for 'cart' were fixed.

magento-cicd2 · 2018-03-24T12:23:08Z

All committers have signed the CLA.

….2.2): - Blank line after variable declarations was added; - Blank line before "if" was added.

ihor-sviziev · 2018-03-24T13:54:55Z

app/code/Magento/Checkout/view/frontend/web/js/view/minicart.js

@@ -94,17 +94,17 @@ define([
                this.isLoading(addToCartCalls > 0);
                sidebarInitialized = false;
                this.update(updatedCart);
+
+                if (cartData()['website_id'] !== window.checkout.websiteId) {


AFAIK this file is using not at checkout page only, so window.checkout will not be available

@ihor-sviziev
I checked your comment.
window.checkout is available on home page and category pages.

Also, I want to tell you, that logic "cartData()['website_id'] !== window.checkout.websiteId" was earlier in Magento.
It was fixed it to remove excessed request.

Will review deeper little bit later

I can confirm that window.checkout property exist at any page where present minicart

Hello, @sidolov
Please check and approve this PR.
Thanks for advance.

ihor-sviziev · 2018-04-05T12:12:54Z

@magento-engcom-team give me new test instance

magento-engcom-team · 2018-04-05T12:14:39Z

Hi @ihor-sviziev, here is your new test Magento instance

…page were fixed #14314

magento-engcom-team · 2018-04-19T18:07:05Z

Hi @andrewbess. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

xmav · 2018-06-05T15:24:47Z

Hi @andrewbess
Changes from this PR cause an issue.
Here is steps to reproduce:

Create Simple product with price=100$ and Qty=100
Go to storefront and add that product to cart with Qty = 5
Notice cart Subtotal in cart and minicart (Both are 500$)
Open Backend in new window(tab) and add Tier price(on Advanced Pricing tab) for that product for Qty=5. You may set discount=5%
Refresh window(tab) with Cart page
Notice cart Subtotal in cart and minicart.
You will see that Subtotal in sidebar is 475 and 500 in Minicart. Please check attached screenshot

Would be great if you can adjust your changes to prevent this issue.

Feel free to contact me if you have questions.

Thanks,
Maksym

andrewbess · 2018-06-06T10:06:34Z

Hello @xmav
Thank you.
I will check it.

xmav · 2018-06-25T09:24:11Z

Code changes has been reverted due to introduced issues

ihor-sviziev · 2018-06-26T12:34:20Z

@xmav there also was forwardport to 2.3-develop #14782. Was it also reverted?

xmav · 2018-06-26T12:43:00Z

@ihor-sviziev yes, it was reverted.

sshymko · 2018-06-28T23:18:19Z

@xmav
Is there an alternative fix to be used instead of the reverted one?

elvinristi · 2018-07-06T09:38:41Z

Problem with this PR is that it probably works only then when you have to show prices excluding tax.

when I update to from "quote.totals().subtotal" to "quote.totals().subtotal_incl_tax" then this works with inclusive tax.

So there should be added some check what is the admin setting - inclusive or exclusive tax and using proper value based on it.

Ctucker9233 · 2019-03-01T18:59:43Z

@xmav Is there an alternate to this fix? It is desperately needed.

magento#13765 Excess requests 'customer data' on checkout cart page w…

d2c6bd0

…ere fixed: - Excess request for 'directory-data' was fixed; - Excess requests for 'cart' were fixed.

osrecio added the Event: distributed-cd Distributed Contribution Day label Mar 24, 2018

magento-engcom-team added this to the March 2018 milestone Mar 24, 2018

magento-engcom-team added the Release Line: 2.2 label Mar 24, 2018

magento#13765 "cart" section data gets loaded 3 times on cart page (2…

42350cd

….2.2): - Blank line after variable declarations was added; - Blank line before "if" was added.

mslabko approved these changes Mar 24, 2018

View reviewed changes

ihor-sviziev reviewed Mar 24, 2018

View reviewed changes

andrewbess closed this Mar 26, 2018

andrewbess reopened this Mar 26, 2018

ihor-sviziev self-requested a review March 27, 2018 18:34

ihor-sviziev self-assigned this Mar 28, 2018

magento-engcom-team assigned sidolov Apr 16, 2018

okorshenko modified the milestones: March 2018, April 2018 Apr 16, 2018

magento-engcom-team mentioned this pull request Apr 19, 2018

"cart" section data gets loaded 3 times on cart page (2.2.2) #13765

Closed

magento-engcom-team merged commit 42350cd into magento:2.2-develop Apr 19, 2018

magento-engcom-team pushed a commit that referenced this pull request Apr 19, 2018

ENGCOM-1059: #13765 Excess requests 'customer data' on checkout cart …

674a837

…page were fixed #14314

ishakhsuvarov assigned mslabko, ihor-sviziev and sidolov and unassigned ihor-sviziev and sidolov Apr 19, 2018

andrewbess mentioned this pull request Apr 20, 2018

[Forwardport] magento/magento2#13765 Excess requests 'customer data' on checkout cart page were fixed andrewbess/magento2ce#1

Merged

4 tasks

ihor-sviziev mentioned this pull request Apr 20, 2018

[Forwardport] magento/magento2#13765 Excess requests 'customer data' on checkout cart page were fixed #14781

Closed

4 tasks

andrewbess mentioned this pull request Apr 20, 2018

[Forwardport] magento/magento2#13765 Excess requests 'customer data' on checkout cart page were fixed #14782

Merged

4 tasks

sidolov mentioned this pull request Apr 23, 2018

Avoid getShippingRates().subscribe to be called twice #14160

Closed

4 tasks

ihor-sviziev removed their request for review June 26, 2018 12:36

dmanners mentioned this pull request Apr 6, 2019

Avoid getShippingRates().subscribe to be called twice #14081

Closed

andrewbess deleted the issue-13765 branch November 13, 2019 08:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

magento/magento2#13765 Excess requests 'customer data' on checkout cart page were fixed #14314

magento/magento2#13765 Excess requests 'customer data' on checkout cart page were fixed #14314

andrewbess commented Mar 24, 2018 •

edited

magento-cicd2 commented Mar 24, 2018 •

edited

ihor-sviziev Mar 24, 2018

andrewbess Mar 26, 2018 •

edited

ihor-sviziev Mar 27, 2018

sidolov Apr 17, 2018

andrewbess Apr 18, 2018

ihor-sviziev commented Apr 5, 2018

magento-engcom-team commented Apr 5, 2018

magento-engcom-team commented Apr 19, 2018

xmav commented Jun 5, 2018

andrewbess commented Jun 6, 2018

xmav commented Jun 25, 2018

ihor-sviziev commented Jun 26, 2018

xmav commented Jun 26, 2018

sshymko commented Jun 28, 2018

elvinristi commented Jul 6, 2018

Ctucker9233 commented Mar 1, 2019

magento/magento2#13765 Excess requests 'customer data' on checkout cart page were fixed #14314

magento/magento2#13765 Excess requests 'customer data' on checkout cart page were fixed #14314

Conversation

andrewbess commented Mar 24, 2018 • edited

Description

Fixed Issues (if relevant)

Steps to reproduce

Expected result

Actual result

Contribution checklist

magento-cicd2 commented Mar 24, 2018 • edited

ihor-sviziev Mar 24, 2018

Choose a reason for hiding this comment

andrewbess Mar 26, 2018 • edited

Choose a reason for hiding this comment

ihor-sviziev Mar 27, 2018

Choose a reason for hiding this comment

sidolov Apr 17, 2018

Choose a reason for hiding this comment

andrewbess Apr 18, 2018

Choose a reason for hiding this comment

ihor-sviziev commented Apr 5, 2018

magento-engcom-team commented Apr 5, 2018

magento-engcom-team commented Apr 19, 2018

xmav commented Jun 5, 2018

andrewbess commented Jun 6, 2018

xmav commented Jun 25, 2018

ihor-sviziev commented Jun 26, 2018

xmav commented Jun 26, 2018

sshymko commented Jun 28, 2018

elvinristi commented Jul 6, 2018

Ctucker9233 commented Mar 1, 2019

andrewbess commented Mar 24, 2018 •

edited

magento-cicd2 commented Mar 24, 2018 •

edited

andrewbess Mar 26, 2018 •

edited