Fixed anchor categories showing products of disabled subcategories #9002 #14320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidolov
requested changes
Mar 26, 2018
| * @return string | ||
| * @since 101.0.0 | ||
| */ | ||
| protected function makeTempCategoryTreeIndex() | ||
| protected function makeTempCategoryTreeIndex(\Magento\Store\Model\Store $store) |
There was a problem hiding this comment.
We can't add/remove any parameters to public and protected method, please, use guide for backward compatible developpmenet
| * @param string $temporaryName | ||
| * @since 101.0.0 | ||
| */ | ||
| protected function fillTempCategoryTreeIndex($temporaryName) | ||
| protected function fillTempCategoryTreeIndex($temporaryName, \Magento\Store\Model\Store $store) |
|
@drashmk , I am closing this PR now due to inactivity. |
|
Hi @drashmk. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incomplete query for the temporary table
temp_catalog_category_tree_index_xxxxwas causing products of disabled subcategories to be visible on anchor categories. It was missing the check foris_activecategory attribute on the child category when creating the temporary category.Fixed Issues (if relevant)
#9002: Anchor categories are showing products of disabled subcategories
Manual testing scenarios
Contribution checklist