Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #13950 - Cache issue with configurable products related to currency-conversions #14559

Merged
merged 1 commit into from Apr 11, 2018

Conversation

@nuzil
Copy link
Contributor

nuzil commented Apr 5, 2018

Its a new Pull request for #14017
Old one can be closed

Preconditions.

Magento website with configured multiple currencies, for some of currencies not configured currency symbol.

Problem.

Two Magento block classes used in generating cache key (in method getCacheKeyInfo()) current currency symbol. It leads to problem that these blocks has same cache for different currencies which has no symbol configured.

Solution.

Use currency code instead currency symbol in cache key generating to get unique cache of these block for different currencies.

Solution:
Use currency code instead currency symbol in cache key generating to get unique cache of these block for different currencies.
@orlangur orlangur self-assigned this Apr 9, 2018
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Apr 9, 2018

Hi @orlangur, thank you for the review.
ENGCOM-1245 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 9c8d82c into magento:2.2-develop Apr 11, 2018
3 checks passed
3 checks passed
Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
magento-engcom-team pushed a commit that referenced this pull request Apr 11, 2018
…ducts related to currency-conversions #14559
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Apr 11, 2018

Hi @nuzil. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.