Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Add expanded documentation to AdapterInterface::update #14769

Merged
merged 1 commit into from Apr 20, 2018
Merged

[Backport] Add expanded documentation to AdapterInterface::update #14769

merged 1 commit into from Apr 20, 2018

Conversation

navarr
Copy link
Member

@navarr navarr commented Apr 19, 2018

Original Pull Request

#14755
This adds a long description to AdapterInterface::update detailing how the $where parameter works

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@navarr
Add expanded documentation to AdapterInterface::update
b61dd0e 
This adds a long description to AdapterInterface::update detailing how the `$where` parameter works
@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 19, 2018
magento-team pushed a commit that referenced this pull request Apr 20, 2018
@sidolov
ENGCOM-1338: [Backport] Add expanded documentation to AdapterInterfac…
4da70ee 
…e::update #14769
@magento-engcom-team magento-engcom-team merged commit b61dd0e into magento:2.2-develop Apr 20, 2018
@magento-engcom-team
Copy link
Contributor

Hi @navarr. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

@navarr navarr deleted the 2.2-develop-PR-port-14755 branch June 27, 2018 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VladimirZaets VladimirZaets

Labels
Progress: accept Release Line: 2.2
Projects
None yet
Milestone
April 2018
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@navarr @magento-engcom-team @VladimirZaets