Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Block Config Source #16021

Merged
merged 2 commits into from Aug 14, 2018
Merged

Conversation

@thomas-kl1
Copy link
Member

thomas-kl1 commented Jun 11, 2018

Add a new OptionSource of Blocks

Description

Pages config source is useful to create custom configuration, for example to set page. The same for the block could be useful too.
So I suggest to add the blocks config source.

@magento-cicd2

This comment has been minimized.

Copy link
Contributor

magento-cicd2 commented Jun 11, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.7 milestone Aug 10, 2018
@magento-engcom-team magento-engcom-team merged commit e4ede9b into magento:2.2-develop Aug 14, 2018
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
magento-engcom-team pushed a commit that referenced this pull request Aug 14, 2018
@magento-engcom-team magento-engcom-team added this to Ready to Port in Ports Wanted Aug 14, 2018
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Aug 14, 2018

Hi @thomas-blackbird. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@magento-engcom-team magento-engcom-team moved this from Ready to Port to Port to 2.3 Created in Ports Wanted Aug 14, 2018
@thomas-kl1 thomas-kl1 deleted the thomas-kl1:feature/cms-block-source branch Aug 14, 2018
@magento-engcom-team magento-engcom-team moved this from Port to 2.3 Created to Port to 2.3 Merged in Ports Wanted Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Ports Wanted
  
Port to 2.3 Merged
4 participants
You can’t perform that action at this time.