Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Submitting search form (mini) with enter key fires event handlers bound by jquery twice #16281

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Jun 21, 2018

Original Pull Request

#15340

Description

When submitting the search form in the header with the enter key on the keyboard, event handlers that were bound to the form submit (through jQuery) are fired twice.

Fixed Issues (if relevant)

  1. Submitting search form (mini) with enter key fires event handlers bound by jquery twice #13793: Submitting search form (mini) with enter key fires event handlers bound by jquery twice

Manual testing scenarios

  1. Create a javascript which adds an event handler to the form submit
  2. $('#search_mini_form').on('submit', function(e) {
    console.log('listening for form submit');
    });
  3. Submit the search form in the header with a value by pressing the enter button

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur
Copy link
Contributor

@vgelani please rewrite branch history so that author of original commit is preserved, also, always add [Backport]/[Forwardport] to issue title.

@gelanivishal gelanivishal changed the title Submitting search form (mini) with enter key fires event handlers bound by jquery twice [Backport] Submitting search form (mini) with enter key fires event handlers bound by jquery twice Jun 22, 2018
@gelanivishal
Copy link
Contributor Author

@orlangur I have updated PR title.
please rewrite branch history so that author of original commit is preserved

  • I don't understand what do you want to say?

Thank you.

@orlangur
Copy link
Contributor

@vgelani backport PR must contain author of original PR 153faa6, please cherry-pick this commit and do force push instead of just doing same changes.

@gelanivishal
Copy link
Contributor Author

@orlangur I have created manual changes because porting tool is failed to create a PR. In case of this, I have created manual create PR with the same commit message.

@orlangur
Copy link
Contributor

@vgelani it does not matter how you created PR, original PR author must be credited properly. Easiest way is to do cherrypicking.

@gelanivishal
Copy link
Contributor Author

@orlangur Yeah, I got it by Magento maintainers what is cherrypicking. But It didn't work now for this PR. I'll take care of new PR.

Thank you.

@magento-engcom-team
Copy link
Contributor

Hi @vgelani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants