-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work if use date as condition for Catalog Price Rules #16855
Doesn't work if use date as condition for Catalog Price Rules #16855
Conversation
Hi @GlennCheng. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @GlennCheng. Thanks for collaboration. Please provide more details and steps to reproduce this issue. |
+1 to what @VladimirZaets said, the use of the template is mandatory. |
@miguelbalparda @VladimirZaets In Rule/Model/Condition/AbstractCondition.php#Line:694 In CatalogRule/Model/Rule/Condition/Product.php#Line:37: |
@miguelbalparda |
Hi @GlennCheng. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
Fix following issue:
Doesn't work if use date as condition for Catalog Price Rules.
Manual testing scenarios
add or edit a Rule, then if use date as a condition, that condition doesn't work.
Contribution checklist