Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a couple of spelling mistakes #16980

Merged
merged 3 commits into from Jul 23, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -14,5 +14,5 @@ class Attribute extends \Magento\Backend\Block\Template
/**
* @var string
*/
protected $_template = 'catalog/product/attribute/set/main/tree/attribute.phtml';
protected $_template = 'Magento_Catalog::catalog/product/attribute/set/main/tree/attribute.phtml';
}
Expand Up @@ -67,7 +67,7 @@ define([
},

/**
* Has weight swither
* Has weight switcher
* @returns {*}
*/
hasWeightSwither: function () {
Expand Down
Expand Up @@ -140,7 +140,7 @@ protected function setUp()
}

/**
* Successfull case
* Successful case
*/
public function testExecuteSuccessfully()
{
Expand Down
Expand Up @@ -46,7 +46,7 @@ define([
}

/**
* Creates observable propery using 'track' method.
* Creates observable property using 'track' method.
*
* @param {Object} obj - Object to whom property belongs.
* @param {String} key - Key of the property.
Expand Down
Expand Up @@ -18,7 +18,7 @@
class AssertWidgetCmsPageLink extends AbstractConstraint
{
/**
* Assert that created widget displayed on frontent on Home page and on Advanced Search and
* Assert that created widget displayed on frontend on Home page and on Advanced Search and
* after click on widget link on frontend system redirects you to cms page.
*
* @param CmsIndex $cmsIndex
Expand Down
Expand Up @@ -6,6 +6,6 @@

\Magento\Framework\Component\ComponentRegistrar::register(
\Magento\Framework\Component\ComponentRegistrar::THEME,
'frontent/Test/theme',
'frontend/Test/theme',
__DIR__
);
@@ -1,2 +1,2 @@
module Magento_Module *
theme frontent/Test/theme One*
theme frontend/Test/theme One*
Expand Up @@ -46,7 +46,7 @@ public function process(File $phpcsFile, $stackPtr)
}

if ($tokens[$prevPtr]['line'] === $tokens[$stackPtr]['line']) {
$error = 'Each propery must be on a line by itself';
$error = 'Each property must be on a line by itself';
$phpcsFile->addError($error, $stackPtr, 'SameLine');
}
}
Expand Down
Expand Up @@ -290,7 +290,7 @@ public function testAsymmetricRollBackSuccess()
}

/**
* Test successfull nested transaction
* Test successful nested transaction
*/
public function testNestedTransactionCommitSuccess()
{
Expand All @@ -312,7 +312,7 @@ public function testNestedTransactionCommitSuccess()
}

/**
* Test successfull nested transaction
* Test successful nested transaction
*/
public function testNestedTransactionRollBackSuccess()
{
Expand All @@ -334,7 +334,7 @@ public function testNestedTransactionRollBackSuccess()
}

/**
* Test successfull nested transaction
* Test successful nested transaction
*/
public function testNestedTransactionLastRollBack()
{
Expand Down
2 changes: 1 addition & 1 deletion lib/web/mage/utils/objects.js
Expand Up @@ -83,7 +83,7 @@ define([
* @private
*
* @param {Object} parent - Object from which to remove property.
* @param {Array} path - Splitted path to the propery.
* @param {Array} path - Splitted path to the property.
*/
function removeNested(parent, path) {
var field = path.pop();
Expand Down
2 changes: 1 addition & 1 deletion lib/web/mage/validation/url.js
Expand Up @@ -42,7 +42,7 @@ define([], function () {
/**
* Sanitize url, replacing disallowed chars
*
* @param {Sring} path - url to be normalized
* @param {String} path - url to be normalized
* @returns {String}
*/
sanitize: function (path) {
Expand Down
2 changes: 1 addition & 1 deletion setup/performance-toolkit/README.md
Expand Up @@ -116,7 +116,7 @@ To get more details about available JMeter options, read [Non-GUI Mode](http://j
For example, you can run the B2C scenario via console with 90 threads for the Frontend Pool and 10 threads for the Admin Pool:

cd {JMeter path}/bin/
jmeter -n -t {path to peformance toolkit}/benchmark.jmx -j ./jmeter.log -l ./jmeter-results.jtl -Jhost=magento2.dev -Jbase_path=/ -Jadmin_path=admin -JfrontendPoolUsers=90 -JadminPoolUsers=10
jmeter -n -t {path to performance toolkit}/benchmark.jmx -j ./jmeter.log -l ./jmeter-results.jtl -Jhost=magento2.dev -Jbase_path=/ -Jadmin_path=admin -JfrontendPoolUsers=90 -JadminPoolUsers=10

As a result, you will get `jmeter.log` and `jmeter-results.jtl`. The`jmeter.log` contains information about the test run and can be helpful in determining the cause of an error. The JTL file is a text file containing the results of a test run. It can be opened in the GUI mode to perform analysis of the results (see the *Output* section below).

Expand Down