Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Responsive Layout on Top page #16983

Merged
merged 1 commit into from Jul 27, 2018
Merged

Broken Responsive Layout on Top page #16983

merged 1 commit into from Jul 27, 2018

Conversation

rodrigoobiassi
Copy link
Member

I checked as other pages were behaving to fit the page:
/privacy-policy-cookie-restriction-mode

I got references here:
/customer/account/

1 - Reference:
account-page-main

2 - The issue - Without code right:
without-paddingtop-and-position

3 - With the code right:
with-paddingtop-and-position

Thanks,
Rodrigo Biassi

@magento-engcom-team
Copy link
Contributor

Hi @rodrigoobiassi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

@rodrigoobiassi thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @rodrigoobiassi. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@rodrigoobiassi
Copy link
Member Author

Happy to be able to help.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants