Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spaces around amount span. #17027

Merged
merged 1 commit into from Jul 27, 2018
Merged

Remove spaces around amount span. #17027

merged 1 commit into from Jul 27, 2018

Conversation

likemusic
Copy link
Contributor

Description

There is unnecessary spaces exists around price. Therefor if add some text after span with price there is one crossed space shown after price.

Fixed Issues (if relevant)

No

Manual testing scenarios

  1. Set "Manufacturer's Suggested Retail Price" in "Advanced Pricing" on product edit page.
  2. On frontend add (manually or by js-code) some text after span with crossed price.

Before:
spacearoundpricebuggy

After:
spacearoundpricefixed

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @likemusic. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@aleron75 aleron75 self-assigned this Jul 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-2485 has been created to process this Pull Request

@aleron75
Copy link
Contributor

Hi @likemusic thank you for your submission.

Once merged, don't forget you can easily port this PR to other branches with the Porting Tool, read more here.

@magento-engcom-team
Copy link
Contributor

Hi @likemusic. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants