Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused ID #17335

Merged
merged 1 commit into from Aug 5, 2018
Merged

fix: remove unused ID #17335

merged 1 commit into from Aug 5, 2018

Conversation

DanielRuf
Copy link
Contributor

See #17291

Description

The ID is totally unused so we do not have to use Knockout here and do not even need this ID.

Fixed Issues (if relevant)

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Aug 2, 2018
@orlangur orlangur self-assigned this Aug 2, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2639 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 2ddec42 into magento:2.1-develop Aug 5, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 5, 2018
@sidolov
ENGCOM-2639: fix: remove unused ID #17335
ccbef92
@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

@DanielRuf DanielRuf deleted the fix/remove-unused-id-2-1 branch August 5, 2018 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@sidolov sidolov

Labels
Area: Frontend Cleanup Component: Checkout Progress: accept Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.15
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DanielRuf @magento-engcom-team @orlangur @sidolov