Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braintree: test coverage #17454

Conversation

dmytro-ch
Copy link
Contributor

Description

This PR adds missing unit test for Magento\Braintree\Model\InstantPurchase\CreditCard\AvailabilityChecker class

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

@dmytro-ch dmytro-ch requested a review from rogyar August 8, 2018 21:31
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: Braintree Release Line: 2.2 labels Aug 8, 2018
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Aug 9, 2018

@magento-engcom-team combine 17456 17457

@magento-engcom-team
Copy link
Contributor

Hi @sidolov. Thank you for your request. I'm working on combining the pull requests for you

@magento-engcom-team
Copy link
Contributor

@dmytro-ch all pull requests have been successfully combined together:

@sidolov sidolov changed the title Braintree: Added unit test for AvailabilityChecker Braintree: test coverage Aug 9, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.7 milestone Aug 9, 2018
@magento-engcom-team magento-engcom-team merged commit c06dfb4 into magento:2.2-develop Aug 9, 2018
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants