-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating lib LESS docs #17479
updating lib LESS docs #17479
Conversation
Hi @Karlasa. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me test instance |
Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you |
Hi @Karlasa, here is your new Magento instance. |
docs are cleaned up :) |
Hi @Karlasa. Thanks for collaboration. I think this fixes better to delivery to Magento 2.3 version. This fixes looks like cleanup. But according to Magento Code Contributions Guide we don't delivering code cleanup to Magento 2.2 version |
@VladimirZaets #17097 is backport to 2.2 and was merged so i see no issue about that. And as it's actually just doc about code not code itself. Could as easly called it a bug, because code examples do not work as expected in LESS docs |
@Karlasa The Magento Code Contributions Guide was updated after that PR was merged. But you make sense, this issue we can consider as a bug. |
Hi @Karlasa. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Seems like LESS docs are bit outdated. planning on going through all the files. Here is the first part :)
Description
Keeping LESS lib docs up to date as in PR #11371 .lib-url-check is removed
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist