Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating lib LESS docs #17479

Merged
merged 25 commits into from
Aug 13, 2018
Merged

updating lib LESS docs #17479

merged 25 commits into from
Aug 13, 2018

Conversation

Karlasa
Copy link
Contributor

@Karlasa Karlasa commented Aug 9, 2018

Seems like LESS docs are bit outdated. planning on going through all the files. Here is the first part :)

Description

Keeping LESS lib docs up to date as in PR #11371 .lib-url-check is removed

Fixed Issues (if relevant)

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Karlasa
Copy link
Contributor Author

Karlasa commented Aug 9, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-17479.engcom.dev.magento.com/admin
Login: admin Password: 123123q

@Karlasa
Copy link
Contributor Author

Karlasa commented Aug 9, 2018

docs are cleaned up :)

@VladimirZaets VladimirZaets self-assigned this Aug 9, 2018
@VladimirZaets
Copy link
Contributor

Hi @Karlasa. Thanks for collaboration. I think this fixes better to delivery to Magento 2.3 version. This fixes looks like cleanup. But according to Magento Code Contributions Guide we don't delivering code cleanup to Magento 2.2 version

@Karlasa
Copy link
Contributor Author

Karlasa commented Aug 10, 2018

@VladimirZaets #17097 is backport to 2.2 and was merged so i see no issue about that. And as it's actually just doc about code not code itself. Could as easly called it a bug, because code examples do not work as expected in LESS docs

@VladimirZaets
Copy link
Contributor

@Karlasa The Magento Code Contributions Guide was updated after that PR was merged. But you make sense, this issue we can consider as a bug.

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants