-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translated admin menu titles #17521
Translated admin menu titles #17521
Conversation
Hi @yogeshks. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team combine 17525 |
Hi @sidolov. Thank you for your request. I'm working on combining the pull requests for you |
@yogeshks all pull requests have been successfully combined together:
|
@@ -7,13 +7,6 @@ | |||
--> | |||
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Backend:etc/menu.xsd"> | |||
<menu> | |||
<add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yogeshks. What the reason to move attributes to one line? As for me, the previous format is more readable. Also, Magento has the rules that check line length in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @VladimirZaets, You're right but I had reviewed all menu.xml
files inside app/code/Magento
directory and found that <add>
is written in one line inside all files. This is the only reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VladimirZaets, Please let me know if you still need updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @VladimirZaets, Please let me know, need to update it?
@magento-engcom-team @VladimirZaets Hi, any updates for this PR? |
Hi @yogeshks. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
Added
translate="title"
for admin menusRemoved extra spaces from
<add>
tagsFixed Issues (if relevant)
Manual testing scenarios
Contribution checklist