-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for ProductLink - setterName was incorrectly being set #17773
Conversation
Hi @insanityinside. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @sidolov, thank you for the review. |
…rst instead of converting to camel case, which doesn't work for models with underscores
9e8caa4
to
cac184c
Compare
…verter::snakeCaseToUpperCamelCase to maintain uniformity, and catch an additional case where the same issue occurred
Update for pull request #17773 - now using SimpleDataObjectConverter::snakeCaseToUpperCamelCase to maintain uniformity, and catching a second instance of the same issue in a related class. The Codacy/PR Quality Review doesn't like the static function use. I based the new code on the existing code in lib/internal/Magento/Generator/ExtensionAttributesGenerator.php . If there is a different preferred way to do this, please advise. |
Hi @insanityinside. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Fix for ProductLink - setterName was incorrectly being set to an ucfirst instead of converting to camel case, which doesn't work as expected on attributes with underscores in their names.
To replicate, add a custom product link attribute in an extension that has an underscore in it. The normal expected setter routines in camel case do not work.