Make report bugs link optional

[arnoudhgz]

Description

Make it possible to disable report bugs link.

As developer I have removed this link a lot of times with a layout update (remove=true).

Since we most of the times do not want this by default it should be configurable whether to show this link or not.

A new setting is added under Design > Configuration > Edit > Other Settings > Footer.
The new label for this is 'Display Report Bugs Link'.

The default value for this setting is 'Yes' to keep it backwards compatible.

Manual testing scenarios

1. Default setup with blank theme
2. Go to frontend
3. See 'report bugs' link in footer
4. Go to backend > Design > Configuration > Edit > Other Settings > Footer
5. Set setting 'Display Report Bugs Link' to 'No'
6. Flush cache
7. Go to frontend again
8. See that 'report bugs' link is removed from footer

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @arnoudhgz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[arnoudhgz]

@miguelbalparda any news on your review?

[miguelbalparda]

Yes, this is not going to be included in the next release. I'll report back once 2.3 is out and we can continue working towards 2.3.1. Thanks!

[magento-engcom-team]

Hi @slavvka, thank you for the review.
ENGCOM-3098 has been created to process this Pull Request

[magento-engcom-team]

Hi @arnoudhgz. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

[slavvka]

Please, consider to port this solution to 2.2 release line if applicable
You may use Porting tool (https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html#porting-tool) to port commits automatically.