Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.3] Update labels section in README.md #18136

Merged
merged 2 commits into from Sep 25, 2018
Merged

[2.3] Update labels section in README.md #18136

merged 2 commits into from Sep 25, 2018

Conversation

sidolov
Copy link
Contributor

@sidolov sidolov commented Sep 19, 2018

Description

Updated "Labels applied by Magento team" section in README.md file with reference to the updated documentation.

Fixed Issues (if relevant)

  1. none
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @sidolov. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@lorikrell lorikrell self-requested a review September 19, 2018 14:31
lorikrell
lorikrell reviewed Sep 19, 2018
View reviewed changes
README.md Outdated
| ![needs update](http://devdocs.magento.com/common/images/github_needsUpdate.png) | The Magento Team needs additional information from the reporter to properly prioritize and process the issue or pull request. |

To learn more about issue gate labels click [here](https://github.com/magento/magento2/wiki/Magento-Issue-Gates)
We apply labels to public Pull Requests and Issues to help other participants retrieve additional information about current progress, component assignments, Magento release lines, and much more. Find detailed information about labels used in Magento 2 repositories in the corresponded section of the <a href="https://devdocs.magento.com/guides/v2.3/contributor-guide/contributing.html#labels">Code Contributions</a> guide.
Copy link

@lorikrell lorikrell Sep 19, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would revise the last sentence with:

Please review the <a href="https://devdocs.magento.com/guides/v2.3/contributor-guide/contributing.html#labels">Code Contributions</a> guide for detailed information on labels used in Magento 2 repositories.

lorikrell
lorikrell approved these changes Sep 19, 2018
View reviewed changes
Copy link

@lorikrell lorikrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the edit, review approved from DevDocs.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Sep 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @lorikrell, thank you for the review.
ENGCOM-3016 has been created to process this Pull Request

@sidolov sidolov changed the title Update labels section in README.md [2.3] Update labels section in README.md Sep 19, 2018
@magento-engcom-team magento-engcom-team merged commit 062f586 into magento:2.3-develop Sep 25, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 25, 2018
@sidolov
ENGCOM-3016: Update labels section in README.md #18136
201a340
@magento-engcom-team
Copy link
Contributor

Hi @sidolov. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorikrell lorikrell lorikrell approved these changes

Assignees

@lorikrell lorikrell

Labels
Cleanup Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sidolov @magento-engcom-team @lorikrell