Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGENTO-18131: Fixed EAV attributes values query #18437

Merged
merged 1 commit into from Oct 16, 2018

Conversation

strell
Copy link
Contributor

@strell strell commented Oct 7, 2018

Description

SQL Join error when using the custom EAV entity together with the standard eav_entity entity table.
Had to add the table alias into the entity_type_id filter condition.

Fixed Issues (if relevant)

  1. Entity Type ID at Join #18131: Entity Type ID at Join

Manual testing scenarios

See issue description

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 7, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-3124 has been created to process this Pull Request

@aleron75
Copy link
Contributor

aleron75 commented Oct 8, 2018

Hello @strell, thanks for your contribution.
Once merged, don't forget you can easily port this PR to other branches, if applicable, with the Porting Tool, read more here.

@magento-engcom-team
Copy link
Contributor

Hi @strell. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants