Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #14571 - Wrong column type when creating temporary tables for flat catalog #18818

Merged
merged 1 commit into from Dec 6, 2018
Merged

Issue #14571 - Wrong column type when creating temporary tables for flat catalog #18818

merged 1 commit into from Dec 6, 2018

Conversation

jasonevans1
Copy link
Contributor

@jasonevans1 jasonevans1 commented Oct 26, 2018

Description (*)

Product Entity IDs above 2147483647 are not copied correctly and flat catalog product fails to rebuild.
Changed the entity_id column in \Magento\Catalog\Model\Indexer\Product\Flat\TableBuilder::_createTemporaryTable to be created with option to set unsigned to true to match the column from original tables.

Fixed Issues (if relevant)

  1. Wrong column type when creating temporary tables for flat catalog #14571: Wrong column type when creating temporary tables for flat catalog

Manual testing scenarios (*)

  1. Load a product with an entity id of 2147483648 or greater.
  2. Enable use flat catalog product configuration
  3. Run bin/magento indexer:reindex catalog_product_flat

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @jasonevans1. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Oct 26, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 26, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3281 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @jasonevans1. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

magento-engcom-team pushed a commit that referenced this pull request Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants