-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue : Left Side Back End Menu Design fix #18687 #18858
Conversation
Hi @suryakant-krish. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @VladimirZaets, thank you for the review. |
@suryakant-krish thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
@@ -273,7 +273,16 @@ | |||
> .submenu { | |||
transform: translateX(0); | |||
visibility: visible; | |||
z-index: @submenu__z-index; | |||
z-index: 698; | |||
overflow-x: scroll; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @suryakant-krish, thanks for collaboration.
Please use overflow-x: auto instead of scroll. Scroll should be added only in cases when it really need, for this functionality, the better way is to use "overflow-x: auto".
@@ -273,7 +273,16 @@ | |||
> .submenu { | |||
transform: translateX(0); | |||
visibility: visible; | |||
z-index: @submenu__z-index; | |||
z-index: 698; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The better way is to use @submenu__z-indexvariable + 1
instead of hardcode.
min-width: 100%; | ||
display: block; | ||
float: left; | ||
max-width: 1640px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Magento frontend dev guide we haven't breakpoint on 1640 window width. Please change it to 1440px
I have updated code as you have mentioned, |
Hi @suryakant-krish, I see that you already fixed code that I am mentioned, but as I see you didn't push changes to PRs branch. You push changes to "fixed-18687" branch, but PR was created from 2.2-develop branch |
hi @VladimirZaets |
Can you please check I have commited all my latest changes. |
@suryakant-krish thanks for your contribution. We'll first merge your pull request to 2.3 and then process this one. |
I have already added forword port for this please check below url. |
[Backport] Fixed 19579: Input type import file alignment issue.
[Backport] Fixed 19573: Alignment Issue when create a new email template admin
[Backport] Fixed icon alignment: Frontend Component theme sort by arrow icon vertical alignment issue. magento#19639
[Backport] Fixed 19791: Logo vertical misalignment.
[Backport] Fixed 19800 Contact us : design improvement
Hi @suryakant-krish , I am closing this pull request, as the forward-port to 2.3 was closed. Please feel free to reopen when the forward port pull request will be merged to 2.3-develop. |
Hi @suryakant-krish, thank you for your contribution! |
Description (*)
Fixed Left Side Back End Menu Design.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)