Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Internet Explorer 11: Edit customer in backend leads sometimes to a "loading circle" and error object does not support method "includes" #19010

Merged
merged 1 commit into from Nov 6, 2018

Conversation

omiroshnichenko
Copy link
Contributor

Description

Replace usage of unsupported includes method with _.contains

Fixed Issues

  1. Internet Explorer 11: Edit customer in backend leads sometimes to a "loading circle" and error object does not support method "includes" #18562: Internet Explorer 11: Edit customer in backend leads sometimes to a "loading circle" and error object does not support method "includes"

Manual testing scenarios

  1. Go to admin using IE11
  2. Customers > All Customers
  3. Click Add New Customer
  4. Open Adresses tab
  5. Open developer tools
  6. No JS errors in console

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…sometimes to a "loading circle" and error object does not support method "includes"
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 2, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @omiroshnichenko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3371 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@omiroshnichenko thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @omiroshnichenko. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants