New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for incorrectly escapeHtml'd JSON in commit b8f78cc6 #19422
Fix for incorrectly escapeHtml'd JSON in commit b8f78cc6 #19422
Conversation
Hi @insanityinside. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @insanityinside,
Please add annotation similar to https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Cms/view/adminhtml/templates/browser/content/uploader.phtml#L156 and add more details on steps to reproduce to reveal an issue.
Changes made as requested. Loading the upload image page on the latest 2.2-develop from the CMS page editor results in a javascript error in the console, due to the JSON being incorrectly encoded and being unable to be parsed. Attempting to add an image will trigger the error as soon as the AJAX page tries to load. |
Hi @orlangur, thank you for the review. |
Hi @insanityinside. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Forward port unnecessary, code is already fixed in 2.3-develop. |
This commit fixes a bug where the resize JSON configuration was incorrectly being HTML encoded before being output, preventing CMS image uploads in the admin due to the Javascript failing on the encoded single quote ->
'
in the code. Relates to new resize code introduced in MAGETWO-94988, commit b8f78cc.