Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Attribute Option with zero at the beginning does not work if there is already option with the same number without the zero [REST API] #19451

Merged
merged 1 commit into from Dec 9, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 29, 2018

Description

Fix: Attribute Option with zero at the beginning does not work if there is already option with the same number without the zero

Fixed Issues

  1. Attribute Option with zero at the bigining does not work if there is already option with the same number without the zero (REST API)) #19436: Attribute Option with zero at the bigining does not work if there is already option with the same number without the zero (REST API)

Manual testing scenarios

  1. Create an attribute (select or multiselect) from the backend (example: attribute_code = brand_number)
  2. add new Option to this attribute from the backend (12345)
  3. Add new Option to this attribute by the REST API (endpoint : /V1/products/attributes/brand_number/options), json = {"option":{"label":"012345"}}
  4. expected result to have two options (12345 and 012345).

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Nov 29, 2018
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 29, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @SikailoISM. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets
Copy link
Contributor

Hi @SikailoISM, please, sign CLA, otherwise, we can't process your pull request.

@VladimirZaets VladimirZaets self-assigned this Nov 29, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3592 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @SikailoISM. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Award: bug fix Component: Catalog Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants