Log jobCode when writing to log with no callback for easier debug #19541
Conversation
|
|
|
Hi @craigcarnell. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
| @@ -298,7 +298,7 @@ protected function _runJob($scheduledTime, $currentTime, $jobConfig, $schedule, | |||
|
|
|||
| if (!isset($jobConfig['instance'], $jobConfig['method'])) { | |||
| $schedule->setStatus(Schedule::STATUS_ERROR); | |||
| throw new \Exception('No callbacks found'); | |||
| throw new \Exception('No callbacks found for cron job %s', $jobCode); | |||
There was a problem hiding this comment.
Did you miss sprintf call here? Better use "This is $string".
Also, please provide more detailed steps to reproduce.
There was a problem hiding this comment.
@orlangur good spot :)
If you have a database converted from M1 to M2, certain crons may no longer exist.
For example: crontab/jobs/catalog_price_rule_update/schedule/cron_expr
However, there is no call back for this cron expr.
So magento error logs just contain 'No callbacks found' for several items. With this code, it now shows which cron job can be removed.
There was a problem hiding this comment.
@orlangur re pushed with sprintf added
|
Hi @orlangur, thank you for the review. |
|
@craigcarnell thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
|
Hi @craigcarnell. Thank you for your contribution. |
Description (*)
When throwing a new exception with no call back, there is no information on which job it is related to. This makes it difficult to debug the issue.
Manual testing scenarios (*)
Contribution checklist (*)