Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Resolved upgrade issue if manufacturer attribute missing [Magento 2.2] #19551

Merged
merged 3 commits into from Mar 8, 2019
Merged

[Backport] Resolved upgrade issue if manufacturer attribute missing [Magento 2.2] #19551

merged 3 commits into from Mar 8, 2019

Conversation

suneet64
Copy link
Contributor

@suneet64 suneet64 commented Dec 4, 2018 •
edited by sivaschenko

[Backport] Original pull request #19514

Resolved upgrade issue if manufacturer attribute missing [Magento 2.2]

Description (*)

A fatal error while setup:upgrade if you are upgrading to Magento v2.2.7 from an earlier version and manufacturer attribute not exist in the existing database.

Fixed Issues (if relevant)

  1. Manufacturer error when upgrading to 2.2.6 #18134: Manufacturer error when upgrading to 2.2.6

Manual testing scenarios (*)

  1. Have a Magento v2.2.5 clean installation.
  2. Remove manufacturer attribute from Stores > Attributes > Product as it is not a system attribute.
  3. Upgrade the Magento to v2.2.7 using command line
  4. Enable the display_errors from app/bootstrap.php file.
  5. Before: Execute setup:upgrade and while upgrading data you will notice a fatal error because of missing manufacturer attribute.
    After: The fatal error disappear in this fix.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @suneet64. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@suneet64 suneet64 mentioned this pull request Dec 4, 2018
Merged
4 tasks
@sivaschenko sivaschenko self-assigned this Dec 5, 2018
@sivaschenko
Copy link
Member

@suneet64 thanks for your contribution, we'll process this pull request once #19514 will be merged

@sivaschenko sivaschenko changed the title Resolved upgrade issue if manufacturer attribute missing [Magento 2.2] [Backport] Resolved upgrade issue if manufacturer attribute missing [Magento 2.2] Dec 5, 2018
@orlangur orlangur self-assigned this Dec 5, 2018
orlangur
orlangur requested changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suneet64 cherry-picks of existing commits must be applied instead of redoing changes.

@suneet64
Copy link
Contributor Author

suneet64 commented Dec 5, 2018

@orlangur In this commit, I have applied the fix for Magento v2.2 and in #19514, for v2.3. The files which I modified for v2.2 do not exist in v2.3. Please let me know the next steps for this.

@hostep hostep mentioned this pull request Dec 11, 2018
Closed
@orlangur
Copy link
Contributor

@suneet64 the best way is to cherry-pick 2.3 commits unchanged and then apply necessary refactoring.

@ghost ghost removed the Progress: on hold label Jan 11, 2019
@suneet64
Copy link
Contributor Author

@orlangur the changes done for 2.3 are already merged and the branch has been deleted. Please suggest the next steps. Thanks!

@sivaschenko
Copy link
Member

Hi @suneet64 can you please cherry-pick both @orlangur and @sidolov commits from the original PR

@suneet64
Copy link
Contributor Author

Hi @sivaschenko, I just cherry picked the commits from the original PR. Please review.

@suneet64 suneet64 force-pushed the manufacturer-attribute-fix-m22 branch from 785ed1a to 4567a1a Compare February 3, 2019 05:39
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4092 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Mar 6, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@p-bystritsky p-bystritsky self-assigned this Mar 6, 2019
@ghost
Copy link

ghost commented Mar 8, 2019

Hi @suneet64, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit 4567a1a into magento:2.2-develop Mar 8, 2019
magento-engcom-team pushed a commit that referenced this pull request Mar 8, 2019
@sivaschenko
ENGCOM-4092: [Backport] Resolved upgrade issue if manufacturer attrib…
05c8b48 
…ute missing [Magento 2.2] #19551
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur requested changes

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@orlangur orlangur

@sivaschenko sivaschenko

@p-bystritsky p-bystritsky

@VasylShvorak VasylShvorak

Labels
Component: ConfigurableProduct Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.9
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@suneet64 @magento-engcom-team @sivaschenko @orlangur @VasylShvorak @sidolov @p-bystritsky