Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Click for price in home page not work #15922 #19663

Merged
merged 4 commits into from Dec 21, 2018

Conversation

ravi-chandra3197
Copy link
Contributor

@ravi-chandra3197 ravi-chandra3197 commented Dec 8, 2018

Description (*)

Fixed Click for price in home page not work #15922

Fixed Issues (if relevant)

  1. Click for price in home page can`t work #15922:Click for price in home page can`t work

Manual testing scenarios (*)

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Dec 8, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-19663.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rogyar rogyar self-assigned this Dec 8, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 8, 2018
Copy link
Contributor

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were the IDs removed?

@rogyar
Copy link
Contributor

rogyar commented Dec 9, 2018

@DanielRuf please, check the previous attempt for details #17376

@DanielRuf
Copy link
Contributor

So these are definitely not used by other scripts and styles?

@rogyar
Copy link
Contributor

rogyar commented Dec 11, 2018

In this particular case, they are not

@sidolov sidolov changed the base branch from 2.3-develop to 2.2-develop December 19, 2018 18:33
@sidolov sidolov changed the base branch from 2.2-develop to 2.3-develop December 19, 2018 18:33
@magento-engcom-team magento-engcom-team merged commit 68636ec into magento:2.3-develop Dec 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ravi-chandra3197. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants