Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on logo upload for Transactional Emails (#20091) #20092

Merged
merged 1 commit into from Feb 13, 2019

Conversation

chaplynsky
Copy link
Contributor

@chaplynsky chaplynsky commented Jan 6, 2019

Description (*)

Changed "fileUploader" to "imageUploader" on line 16.

Fixed Issues (if relevant)

  1. Error when uploading a Transactional Emails logo #20091: Fix error on logo upload for Transactional Emails

Manual testing scenarios (*)

  1. Go to Content>Theme>Design>Configuration>edit any theme>Transactional Emails
  2. Upload logo

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 6, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @chaplynsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@davidverholen

This comment has been minimized.

@magento-engcom-team

This comment has been minimized.

@davidverholen
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 6, 2019
@magento-engcom-team
Copy link
Contributor

Hi @davidverholen, thank you for the review.
ENGCOM-3799 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@chaplynsky thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@sivaschenko
Copy link
Member

Hi @chaplynsky thank you for the contribution. There is an issue on the PR codebase:

Steps to reproduce:

  • Log in to Admin panel;
  • Go to Content->Design->Configuration;
  • Click 'Edit' link in grid ;
  • Click on "Transactional Emails" tab and select "Select from Gallery" button;
  • Select any image and click on "Add Selected" button;
  • Click "Save Configuration" button;

Actual Result:

Error: "email_logo does not contain field 'file'"

image

@chaplynsky
Copy link
Contributor Author

chaplynsky commented Jan 19, 2019

@sivaschenko, I encounter issues with Select from Gallery elsewhere in the Admin panel, may actually open an Issue for that too... Can you check if this same issue exists in the stock 2.3 codebase? The upload didn't work at all before the change I committed, so this issue may not be caused by the PR codebase.

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-20092.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sivaschenko
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your Magento instance.
Admin access: https://i-20092-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@sivaschenko
Copy link
Member

Hi @chaplynsky thanks for your response. Indeed, this problem affect all imageUploader fields and should be addressed in separate issue. We will process this pull request further.

@sivaschenko
Copy link
Member

The problem with selecting from gallery is reported as a separate issue: #21032

@chaplynsky
Copy link
Contributor Author

@sivaschenko thanks for looking into this. Please let me know why the Travis CI build is failing. I'm not sure how to handle that, because this is my first pull request.

@davidverholen
Copy link
Member

  1. Magento\Ups\Model\CarrierTest::testCollectFreeRates
    PHPUnit\Framework\Exception: Notice: Undefined index: GND in /home/travis/build/magento/magento2/dev/tests/integration/testsuite/Magento/Ups/Model/CarrierTest.php:84.

I've seen this error before, It should not be related to this pr

@sivaschenko
Copy link
Member

@chadbean @davidverholen is right, Travis build fail is not related to the PR

@ghost
Copy link

ghost commented Feb 13, 2019

Hi @chaplynsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants