Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wishlist-patch : remove the comment from wishlist product. #20247

Merged
merged 1 commit into from Jan 23, 2019

Conversation

khodu
Copy link
Contributor

@khodu khodu commented Jan 12, 2019

Description (*)

if we try to remove the comment from wishlist product then the 'Comment' value is not deleted if we try to update it then updated.

Fixed Issues (if relevant)

  1. wishlist comment not removed #20245: if we try to remove the comment from wishlist product then the 'Comment' value is not deleted if we try to update it then updated.

Manual testing scenarios (*)

  1. Create simple product
  2. Create customer and Login in Storefront
  3. Add product to wishlist
  4. On 'My Wish List' page add Comment for product
  5. Click 'Update Wish List' button
  6. Remove the created comment
  7. Click 'Update Wish List' button
    now comment is removed.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @khodu. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-3922 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 23, 2019

Hi @khodu, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @khodu. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

1 similar comment
@magento-engcom-team
Copy link
Contributor

Hi @khodu. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants