Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix #20229-Fatal error on product-compare page when attributes not configured #20884

Conversation

vivekkumarcedcoss
Copy link
Contributor

Original Pull Request

#20231

Description (*)

The productAttribute expects second parameter to a string which was failed when $block->getProductAttributeValue($item, $attribute) returns object due to empty value of attribute.
Added a check of is_string since it expect second param to a string.

Update list.phtml for issue #20229

Fixed Issues (if relevant)

1.Issue: #20229
2. ...

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @vivekkumarcedcoss. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Feb 2, 2019

I cannot reproduce this issue on 2.2-develop branch. Looks like the issue/fix is fair for v2.3 only. isDirectivesExists method was added to app/code/Magento/Catalog/Helper/Output.php only for v2.3.
Please, feel free to reopen this PR if you have a way to reproduce the issue on v2.2. Thank you.

@rogyar rogyar closed this Feb 2, 2019
@ghost
Copy link

ghost commented Feb 2, 2019

Hi @vivekkumarcedcoss, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@rogyar rogyar self-assigned this Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants