Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento backend catalog cost without currency symbol #20907

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Feb 3, 2019

Description (*)

Fixed Magento backend catalog "Cost" without currency symbol.

Fixed Issues (if relevant)

  1. Magento backend catalog "Cost" without currency symbol #20906: Magento backend catalog "Cost" without currency symbol

Manual testing scenarios (*)

  1. Navigate to admin catalog product grid
  2. Using "Columns" selection add 'Cost' column in the grid

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@mage2pratik
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your request. I'm working on Magento instance for you

@mage2pratik
Copy link
Contributor Author

#MM19IN

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik, here is your new Magento instance.
Admin access: https://pr-20907.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sivaschenko sivaschenko self-assigned this Feb 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4093 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 12, 2019

Hi @mage2pratik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@orlangur
Copy link
Contributor

orlangur commented Apr 3, 2019

@sivaschenko this PR must be reverted. Did anyone test it at all?

Cost attribute must not appear in grid by default.

@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@orlangur
Copy link
Contributor

@sivaschenko did you assure it is not working properly now?

@mage2pratik mage2pratik deleted the patch-7 branch March 26, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants