Fix $attributes default value

[jlnarvaez]

Description (*)

The method $this->getStringCustomAttributes($attributes) causes Exception when $attributes value is null.
I think that default value for $attributes must be empty array because inside of getStringCustomAttributes() will try to do a foreach to a null value.

Fixed Issues (if relevant)

$attributes default value now is empty array

Manual testing scenarios (*)

1. Inject ImageFactory in your construct method
2. Try to do $this->imageFactory->create($product, $imageId)
3. Will cause Exception

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @jlnarvaez. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[sivaschenko]

Hi @jlnarvaez thanks for updates, please see my review comments

[sivaschenko]

I think the array restriction will result in the TypeError if the $attributes is null.
So I think the code ensuring $attributes is an array should be executed before calling this function

[sivaschenko]

Thanks for update @jlnarvaez ! Finally, could you take a look at the failed static test

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-5434 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-5434 has been created to process this Pull Request

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-5434 has been created to process this Pull Request

[engcom-Delta]

Hi @jlnarvaez with new changes if I do $this->imageFactory->create($product, $imageId), I got broken page(in my case catalog page) where image should be loaded.

Could you take a look?

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-5434 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed

[m2-assistant]

Hi @jlnarvaez, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.